Skip to content

extend tests/others/test_cli_commands.py::TestRunCommand::test_compil… - #15039

Merged
sayakpaul merged 7 commits into
huggingface:mainfrom
sywangyi:extend_test
Oct 26, 2026
Merged

extend tests/others/test_cli_commands.py::TestRunCommand::test_compil…#15039
sayakpaul merged 7 commits into
huggingface:mainfrom
sywangyi:extend_test

Conversation

@sywangyi

@sywangyi sywangyi commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

…e_arg and

tests/others/test_cli_commands.py::TestRunCommand::test_attention_backend_arg to other device

@sayakpaul please help review

@sywangyi
extend tests/others/test_cli_commands.py::TestRunCommand::test_compil…
d65bd79 
…e_arg and

tests/others/test_cli_commands.py::TestRunCommand::test_attention_backend_arg to other device

Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
@github-actions github-actions Bot added tests size/S PR with diff < 50 LOC labels Oct 15, 2026
@sywangyi
update xpu expectation
93006e0 
Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
@github-actions github-actions Bot added size/M PR with diff < 200 LOC and removed size/S PR with diff < 50 LOC labels Oct 15, 2026
@sywangyi
update
c934dce 
Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
@github-actions

github-actions Bot commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hi @sywangyi, thanks for the PR! It does not appear to link an issue it fixes. If this PR addresses an existing issue, please add a closing keyword (e.g. Fixes #1234) to the PR description so the issue is linked. See the contribution guide for more details. If this PR intentionally does not fix a tracked issue, a maintainer can add the no-issue-needed label to silence this reminder.

Please note that PRs without a linked issue are likely to be automatically closed 10 days after this notice.

Once the PR links an issue (or gets the no-issue-needed label), you can ignore this message — it stays here as a comment, but it no longer applies.

sayakpaul
sayakpaul reviewed Oct 15, 2026
View reviewed changes
Comment thread tests/pipelines/marigold/test_marigold_intrinsics.py
)

def test_marigold_intrinsics_einstein_f32_accelerator_G0_S1_P768_E1_B1_M1(self):
expected_slices = Expectations(

@sayakpaul sayakpaul Oct 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems unrelated change.

@sywangyi sywangyi Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_marigold_xxx xpu expection has been updated in torch2.14, so I update it as well, would you suggest me to separate them into anther PR?

@sayakpaul sayakpaul Oct 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah let's do that.

@sywangyi sywangyi Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

sayakpaul and others added 2 commits October 19, 2026 17:41
@github-actions github-actions Bot added size/S PR with diff < 50 LOC and removed size/M PR with diff < 200 LOC labels Oct 20, 2026
@sywangyi
make style
e8d00d6 
Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
@github-actions

github-actions Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

This PR has been automatically closed because it does not link an issue and the reminder above was not addressed within 10 days. If this PR is still relevant, please link the issue it fixes (e.g. Fixes #1234) or ask a maintainer to add the no-issue-needed label, and it can be reopened.

We are experimenting with this process to keep the review queue manageable, and it will sometimes get it wrong. If you think this PR should stay open, please just say so here and we will reopen it — no need to justify it at length.

Thanks again for contributing, and sorry for the noise if we closed this by mistake!

@github-actions github-actions Bot closed this Oct 26, 2026
@sywangyi

sywangyi commented Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

please reopen it @sayakpaul , thanks

@sayakpaul sayakpaul reopened this Oct 26, 2026
@sayakpaul
sayakpaul merged commit 74a2fdd into huggingface:main Oct 26, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sayakpaul sayakpaul sayakpaul approved these changes

Assignees

No one assigned

Labels

size/S PR with diff < 50 LOC tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sywangyi @sayakpaul